Conversation
|
Wow, the animated gifs look very cool; nice addition! Let me know if you want me to also do a code review |
Great! A code review for this PR I imagine you mean? Otherwise there is still a need for reviews on #269 (which indeed this PR has branched off). It's a bigger PR but if you're limited for time even a high level review of the If not I can also wait until @ammedd and @VeckoTheGecko are available again. |
|
I had a quick look at the ProblemSimulator class in simulator.py but have so many meetings and interviews these days that I don't have time for a full review. Would be great if @erikvansebille or @VeckoTheGecko mangage. |
3 participants
This PR makes stylistic changes to how the 'problems' (#269) are displayed to the user during the simulations. The output is now displayed in a dynamic tabular format (using Rich, no new dependencies required).
The waiting times are artificial between each update, it does not actually take this long but the pauses help with the narrative and following along.
I've attached GIFs below showing the output when the problem a) causes a delay which requires re-scheduling or b) enough contingency time in the schedule and the expedition simulation can continue.
Closes #274
a) re-scheduling required ❌
b) enough contingency time ✅